Expand tab to spaces and and cleanup formatting#4154
Merged
sauwming merged 2 commits intopjsip:masterfrom Nov 13, 2024
Merged
Conversation
Contributor
Author
|
@sauwming I had a hard time modifying aconfigure.ac during my previous PRs, so I decided to remove mixed indentation in aconfigure.ac first and clean up the formatting. Let's review this and I'll redo my PR on top. |
sauwming
approved these changes
Nov 13, 2024
Contributor
|
I think it should't format aconfigure which is generated by autoconf tool |
Contributor
Author
Contributor
Author
|
@sauwming is CI failing due to some enviromental issues? I'm not convinced, that formatting led to |
Contributor
Contributor
Author
|
@jimying unfortunately, autoconf 2.71 is not available in Debian 12 (current stable version of OS) |
nanangizz
approved these changes
Nov 13, 2024
Contributor
Contributor
Author
|
@jimying sorry for inconvenience, it's Debian 11 here. We still need to build pjsp for that version of OS. If you insist, I'll regenerate with 2.71 |
This is a followup for pjsip#3292 and pjsip#3210 but regarding aconfigure.ac
1e41224 to
d874eaa
Compare
Contributor
Author
|
regenerated with autoconf 2.71 |
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
Expand tab to spaces and and cleanup formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for #3292 and #3210 but regarding aconfigure.ac